-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DatasetAlias to support dynamic Dataset Event Emission and Dataset Creation #40478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lee-W
force-pushed
the
dataset-alias
branch
2 times, most recently
from
July 2, 2024 03:50
286535c
to
8a62a12
Compare
Lee-W
force-pushed
the
dataset-alias
branch
12 times, most recently
from
July 6, 2024 00:27
a118ff9
to
36608bb
Compare
Finally get the CI green. Will continue work on adding unit tests and docs |
Lee-W
force-pushed
the
dataset-alias
branch
2 times, most recently
from
July 8, 2024 06:18
617eb98
to
43b7673
Compare
uranusjr
reviewed
Jul 8, 2024
uranusjr
reviewed
Jul 8, 2024
Lee-W
force-pushed
the
dataset-alias
branch
3 times, most recently
from
July 8, 2024 11:25
3855047
to
9a8b71c
Compare
Added test cases to cover the changes. Will work on the documentation next |
Lee-W
changed the title
Dataset alias
Add DatasetAlias to support dynamic Dataset definition
Jul 9, 2024
…etadata and test_outlet_dataset_alias
…implify initialization
…to_uri and rename it as extract_event_key
… and forbid passing list of data alias
… to be added in a single task
… only one dataset event
Co-authored-by: Tzu-ping Chung <[email protected]>
Co-authored-by: Tzu-ping Chung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change?
related: #40039 which is inspired #34206
We want to allow
DatasetEvent
andDataset
to be created in a task dynamically.e.g.,
What's change?
Introduced
DatasetAlias
which support the following syntax to create aDataset
and aDatasetEvent
dynamicallyNote
This PR only supports part of the #40039. It does not yet support scheduling based on
DatasetAlias
(will create another PR for that)^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.