-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add region cloud support for azure data factory #40486
base: main
Are you sure you want to change the base?
Add region cloud support for azure data factory #40486
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
operator = get_field(extras, "cloudOperator", strict=True) | ||
if operator == "AzureChina": | ||
azure_cloud = AzureCloud.AzureChinaCloud | ||
elif operator == "AzureUS": | ||
azure_cloud = AzureCloud.AzureUSGovernment | ||
except KeyError: | ||
pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a good idea?
Any new region added by Azure will require code change from Airflow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kzmain not sure why you marked this as resolved. I don't see you addressed this question
Add Azure Data Factory Region Cloud (Azure China & Azure US) support.