Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openlineage: add config to include 'full' task info based on conf setting #40589

Merged
merged 4 commits into from
Jul 16, 2024

Conversation

mobuchowski
Copy link
Contributor

@mobuchowski mobuchowski commented Jul 3, 2024

After https://github.com/apache/airflow/pull/38264/files we got feedback that some people benefit from additional data - especially operator-specific ones, and aren't concerned with huge event size.

This PR adds way to enable that behavior - turned off by default.

@mobuchowski mobuchowski marked this pull request as ready for review July 8, 2024 13:28
Copy link
Contributor

@kacpermuda kacpermuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments. LGTM overall

Copy link
Member

@jedcunningham jedcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor nits, feel free to accept or reject them.

docs/apache-airflow-providers-openlineage/guides/user.rst Outdated Show resolved Hide resolved
docs/apache-airflow-providers-openlineage/guides/user.rst Outdated Show resolved Hide resolved
docs/apache-airflow-providers-openlineage/guides/user.rst Outdated Show resolved Hide resolved
Copy link
Member

@kaxil kaxil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved in advance assuming Jed's feedback would be addressed

@mobuchowski mobuchowski merged commit 37a5761 into main Jul 16, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants