Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(build): uplift Lerna + replace insecure shortid with nanoid + uplift Yeoman-related packages + ESM-ize generator-superset #29419

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

feat(build): uplift Lerna + replace insecure shortid with nanoid + uplift Yeoman-related packages + ESM-ize generator-superset #29419

wants to merge 13 commits into from

Conversation

hainenber
Copy link
Contributor

@hainenber hainenber commented Jun 30, 2024 •
edited
Loading

feat(build): uplift major version for CI-related packages

SUMMARY

Uplift major version for notable CI-related packages. Notable changes:

  • Uplift Lerna v6 to latest v8
  • Replace unsupported and insecure shortid with successor nanoid + corresponding refactors
  • Uplift yeoman-related packages to latest v7
  • ESM-ize the generator-superset package in order to work with yeoman-generator v7

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@hainenber
feat(pkg/generator): ESM-ize the package + uplift Yeoman-related libr…
d4cec32 
…aries + fix Jest tests + add specific ESLint config

Signed-off-by: hainenber <[email protected]>
@github-actions github-actions bot added the github_actions Pull requests that update GitHub Actions code label Jul 13, 2024
@hainenber hainenber marked this pull request as ready for review July 14, 2024 05:17
@hainenber hainenber changed the title feat(build): uplift major version for CI-related packages feat(build): uplift Lerna + replace insecure shortid with nanoid + uplift Yeoman-related packages + ESM-ize generator-superset Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@villebro villebro Awaiting requested review from villebro villebro is a code owner

@geido geido Awaiting requested review from geido geido is a code owner

@eschutho eschutho Awaiting requested review from eschutho eschutho is a code owner

@rusackas rusackas Awaiting requested review from rusackas rusackas is a code owner

@betodealmeida betodealmeida Awaiting requested review from betodealmeida betodealmeida is a code owner

@nytai nytai Awaiting requested review from nytai nytai is a code owner

@mistercrunch mistercrunch Awaiting requested review from mistercrunch mistercrunch is a code owner

@craig-rueda craig-rueda Awaiting requested review from craig-rueda craig-rueda is a code owner

@john-bodley john-bodley Awaiting requested review from john-bodley john-bodley is a code owner

@kgabryje kgabryje Awaiting requested review from kgabryje kgabryje is a code owner

@dpgaspar dpgaspar Awaiting requested review from dpgaspar dpgaspar is a code owner

@jinghua-qa jinghua-qa Awaiting requested review from jinghua-qa jinghua-qa is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
dependencies:npm github_actions Pull requests that update GitHub Actions code packages review:draft size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hainenber @michael-s-molina