Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ISO code of Île-de-France in france_regions.geojson #29441

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AurelienC
Copy link

SUMMARY

Change the value of ISO for Île-de-France from "FR-IDF\t" to "FR-IDF"

Change the value of ISO for Île-de-France from "FR-IDF\t" to "FR-IDF"
@dosubot dosubot bot added the viz:charts:geojson Related to the deck.gl Geojson label Jul 1, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@rusackas
Copy link
Member

rusackas commented Jul 1, 2024

Thank you for this, but if you don't make a change in the jupyter notebook, the geojson you've changed here will be overwritten next time someone runs the notebook.

Hopefully this helps, but if not, I'd be happy to update it:
https://preset.io/blog/how-and-when-and-why-to-update-apache-supersets-country-maps/

@mistercrunch
Copy link
Member

Oops disregard my approval I had not seen @rusackas ' comment

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking here just to make sure the Jupyter notebook gets updated :D

@AurelienC
Copy link
Author

Thanks, I will have a look!

@mistercrunch mistercrunch changed the title Fix ISO code of Île-de-France in france_regions.geojson fix: ISO code of Île-de-France in france_regions.geojson Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugins size/XS viz:charts:geojson Related to the deck.gl Geojson
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants