Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable customizing the docker admin password #29498

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

c-w
Copy link
Member

@c-w c-w commented Jul 5, 2024

SUMMARY

This PR modifies the docker-compose setup to enable customizing the password used for the admin user. This is useful in scenarios where we want to use the docker-compose setup to spin up a self-contained superset instance but when we don't want to risk someone being able to log in as an admin with the known default credentials.

TESTING INSTRUCTIONS

  1. Configure password override: echo 'ADMIN_PASSWORD=supersecret' > docker/.env-local
  2. Run the stack: TAG=4.0.2 docker compose -f docker-compose-image-tag.yml up
  3. Go to http://localhost:8088 and log in using username admin and the password from step 1

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added authentication Related to authentication install:docker Installation - docker container labels Jul 5, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@mistercrunch mistercrunch merged commit ee72d6c into apache:master Jul 8, 2024
35 of 36 checks passed
@mistercrunch
Copy link
Member

Thanks for the contribution!

@c-w c-w deleted the configure-admin-password branch July 8, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
authentication Related to authentication install:docker Installation - docker container size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants