Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update Michigan polygon #29503

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jpmonette
Copy link

@jpmonette jpmonette commented Jul 5, 2024

SUMMARY

The purpose of this PR is to refine the look & feel of the Michigan state on the legacy-plugin-chart-country-map, so the polygon does not include one of the great lakes.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before

image

After

image

TESTING INSTRUCTIONS

  1. Create chart
  2. Pick Country Map
  3. Select US
  4. Select any metrics / ISO
  5. Generate US Map

ADDITIONAL INFORMATION

  • Has associated issue: Incorrect Michigan State in Country Map #29485
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@jpmonette jpmonette changed the title update Michigan polygon fix: update Michigan polygon Jul 5, 2024
@dosubot dosubot bot added the viz:charts:geojson Related to the deck.gl Geojson label Jul 5, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@rusackas
Copy link
Member

rusackas commented Jul 7, 2024

Well, that's odd... both that it happened, and that nobody has complained!

The help here is much appreciated, but could you make the change via the Jupyter Notebook? Changes made directly to geojson files are doomed to be overwritten. Hope this helps.

@jpmonette
Copy link
Author

jpmonette commented Jul 9, 2024

@rusackas This seems to be private Notion content.

Capture d’écran, le 2024-07-09 à 15 03 15

Also regarding patching this single state in the US geojson, where should that polygon reside?

@rusackas
Copy link
Member

rusackas commented Jul 9, 2024

Hah, that's because I accidentally sent the draft content, not the actual published post! Sorry 😊

https://preset.io/blog/how-and-when-and-why-to-update-apache-supersets-country-maps/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugins size/XS viz:charts:geojson Related to the deck.gl Geojson
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants