Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Download to CSV shows a special Chinese characters #29506

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Habeeb556
Copy link

fix: Download to CSV shows a special Chinese characters.

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

(FIX) Download to CSV shows a special Chinese character apache#29410
@dosubot dosubot bot added data:csv Related to import/export of CSVs i18n:chinese Translation related to Chinese language labels Jul 6, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@rusackas rusackas requested a review from dpgaspar July 7, 2024 04:47
Copy link

codecov bot commented Jul 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.69%. Comparing base (76d897e) to head (00c2ef2).
Report is 414 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #29506       +/-   ##
===========================================
+ Coverage   60.48%   83.69%   +23.20%     
===========================================
  Files        1931      521     -1410     
  Lines       76236    37488    -38748     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    31376    -14738     
+ Misses      28017     6112    -21905     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 49.05% <ø> (-0.12%) ⬇️
javascript ?
mysql 77.02% <ø> (?)
postgres 77.10% <ø> (?)
presto 53.67% <ø> (-0.14%) ⬇️
python 83.69% <ø> (+20.20%) ⬆️
sqlite 76.58% <ø> (?)
unit 59.63% <ø> (+2.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mistercrunch
Copy link
Member

mistercrunch commented Jul 8, 2024

Let's not downgrade every single installs because of a particular issue that's important to a few, as it's fair to assume that many others may need the progress that exists since that version was published. Is there a werkzeug-specific documented issue for this? I'd much rather push forward rather then stepping back.

If we think this is important enough to prevent certain version, the proper way to do it would be to change the range in pyproject.toml and add a comment right above where we set the range explaining why the upper bound is in effect, ideally linking to a werkzeug-hosted issue.

@Habeeb556
Copy link
Author

Let's not downgrade every single installs because of a particular issue that's important to a few, as it's fair to assume that many others may need the progress that exists since that version was published. Is there a werkzeug-specific documented issue for this? I'd much rather push forward rather then stepping back.

If we think this is important enough to prevent certain version, the proper way to do it would be to change the range in pyproject.toml and add a comment right above where we set the range explaining why the upper bound is in effect, ideally linking to a werkzeug-hosted issue.

I agree with you; I think it's related to non-English characters. I've opened a bug issue case with Werkzeug to check on this: pallets/werkzeug#2922. This bug appeared starting from version 3.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:csv Related to import/export of CSVs i18n:chinese Translation related to Chinese language size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants