Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add frontend dependency installation steps #29510

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

CodeWithEmad
Copy link
Contributor

This PR adds explicit instructions for installing frontend dependencies and compiling translations to our setup documentation. These steps were previously omitted, which could confuse new contributors.

Changes Made

  • Added instructions to navigate to the superset-frontend/ directory
  • Included a step to run npm ci for installing dependencies
  • Added a comment for compiling frontend translations

This commit adds explicit instructions for installing frontend dependencies
and a comment for compiling translations, which were previously omitted. While these steps
might be obvious to experienced contributors, they are crucial for new users trying to set up the project for the first time.
@github-actions github-actions bot added the doc Namespace | Anything related to documentation label Jul 7, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@CodeWithEmad
Copy link
Contributor Author

@rusackas I can't see the details of failed jobs. It just says: This job failed :)
That's odd considering the change I made. Can you shed some light on this?

@rusackas
Copy link
Member

rusackas commented Jul 9, 2024

Actually, that's very odd... it doesn't even say why they failed. I'm restarting them, and hopefully they'll go through this time 🤞

@rusackas
Copy link
Member

rusackas commented Jul 9, 2024

CI passed!

@rusackas rusackas merged commit bea4882 into apache:master Jul 9, 2024
35 of 36 checks passed
@CodeWithEmad CodeWithEmad deleted the docs/translations branch July 10, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Namespace | Anything related to documentation size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants