Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: cleanup markdown warnings #29511

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

CodeWithEmad
Copy link
Contributor

This will clean the markdown warnings in the docs:

  • Lists should be surrounded by blank lines.
  • Fenced code blocks should have a language specified.
  • Multiple consecutive blank lines.
  • No trailing punctuation in heading
  • Headings should be surrounded by blank lines.
  • Fenced code blocks should be surrounded by blank lines.

- Lists should be surrounded by blank lines.
- Fenced code blocks should have a language specified.
- Multiple consecutive blank lines.
- No trailing punctuation in heading
- Headings should be surrounded by blank lines.
- Fenced code blocks should be surrounded by blank lines.
@github-actions github-actions bot added the doc Namespace | Anything related to documentation label Jul 7, 2024
@rusackas rusackas requested a review from sfirke July 8, 2024 17:19
@rusackas
Copy link
Member

rusackas commented Jul 8, 2024

Love it! Running CI.

I also wonder if it's possible to add eslint config for this, so that they're automatically kept clean from these sorts of things.

@CodeWithEmad
Copy link
Contributor Author

It might get a bit challenging since some warnings like inline HTML are still there and I didn't want to touch them (do we want to remove them all?) but it would be interesting.

Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

@mistercrunch mistercrunch merged commit 1682994 into apache:master Jul 8, 2024
35 of 36 checks passed
@CodeWithEmad CodeWithEmad deleted the docs/cleanup branch July 8, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Namespace | Anything related to documentation size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants