Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat implementation / #1020 #1024

Merged
merged 3 commits into from
Jul 9, 2024
Merged

Conversation

blackviking27
Copy link
Contributor

Copy link

vercel bot commented Jul 2, 2024

@blackviking27 is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

@blackviking27 blackviking27 changed the title conversation bubble width fix Feat implementation / #1020 Jul 2, 2024
Copy link

vercel bot commented Jul 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 4, 2024 3:16pm

Copy link
Collaborator

@ManishMadan2882 ManishMadan2882 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect @blackviking27 ,
Requesting a minor change as mentioned in the issue:

  • Please make sure that the three buttons for copy, like, dislike should be shifted to bottom of the response as in Mobile width.

Thankyou.

@blackviking27
Copy link
Contributor Author

@ManishMadan2882 Should I remove the visible on hover functionality for the 3 icons. It is causing below ui issues

  1. Only visible when we hover over the parent conversation bubble div and cannot click on it when mouse moves out of the bubble for computers
  2. Overlaps with new conversation bubble as seen in the below image.

correct-search

@ManishMadan2882
Copy link
Collaborator

@blackviking27,
Think that the overlapping can be fixed, and lets make sure that we require hover to display the icons for now.
Thankyou.

@blackviking27
Copy link
Contributor Author

@ManishMadan2882 implemented the changes, please check and let me know if anything else is required

Copy link
Collaborator

@ManishMadan2882 ManishMadan2882 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect changes @blackviking27
Thankyou!

@dartpain dartpain merged commit 1776f6e into arc53:main Jul 9, 2024
2 of 3 checks passed
@blackviking27 blackviking27 deleted the feat-bubble-width branch July 9, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants