Solved: Query Bar Overflow with Long Text Input #1025
+19
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sarthaklaptop is attempting to deploy a commit to the Arc53 Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
2 tasks
siiddhantt
reviewed
Jul 9, 2024
| @@ -33,6 +33,22 @@ export default function Conversation() { | |||
| const [lastQueryReturnedErr, setLastQueryReturnedErr] = useState(false); | |||
| const { t } = useTranslation(); | |||
|
|
|||
| const [inputValue, setInputValue] = useState(''); | |||
|
|
|||
| const handleInput = (e: any) => { | |||
There was a problem hiding this comment.
Please try to avoid type any as much as possible
siiddhantt
reviewed
Jul 9, 2024
| id="inputbox" | ||
| ref={inputRef} | ||
| tabIndex={1} | ||
| placeholder="Type your question here" |
There was a problem hiding this comment.
Needs to be placeholder={t('inputPlaceholder')} for translation
siiddhantt
reviewed
Jul 9, 2024
| @@ -33,6 +33,22 @@ export default function Conversation() { | |||
| const [lastQueryReturnedErr, setLastQueryReturnedErr] = useState(false); | |||
| const { t } = useTranslation(); | |||
|
|
|||
| const [inputValue, setInputValue] = useState(''); | |||
There was a problem hiding this comment.
Is this state needed if it's not being used?
|
Hello @siiddhantt made all the changes you mentioned please review !!! |
|
hi @sarthaklaptop you don't need to make changes to the lint rules |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Query-bar-overflow-issue solved
Before
After
Why was this change needed? (You can also link to an open issue here)
While typing long sentences the last typed word OR while pasting the text the last sentences were not visible.
Other information: