Add type definitions for node-nlp

[Aziz-AXG]

Add type definitions for node-nlp

This PR adds TypeScript type definitions for the node-nlp library.

What is included

• Type definitions for the NlpManager class and its methods (addDocument, addAnswer, process, train).
• Interfaces for Explanation, Classification, Answer, Sentiment, NluAnswer, and NlpResult.
• A tsconfig.json for the type definitions.
• Tests for the type definitions in node-nlp-tests.ts.

Why

Providing type definitions for node-nlp will improve type safety and developer experience for TypeScript users.

Reference

• node-nlp GitHub repository

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[Apollon77]

Hi, Why you provider the types in a separate directory? This is a monorepo with many packages included, so types need to go into the relevant package directories and also added there to the package.json to be picked up at all, else they are not published and are not used at all

[Aziz-AXG]

Hi, Why you provider the types in a separate directory? This is a monorepo with many packages included, so types need to go into the relevant package directories and also added there to the package.json to be picked up at all, else they are not published and are not used at all

do you mean I must add in
https://github.com/axa-group/nlp.js/tree/master/packages/node-nlp/src
as @types/index.d.ts file ?
and add "types": "src/@types/index.d.ts", to package.json ?

[Apollon77]

Just do as index.d.ts in the src of that project. no need (in my eyes) for another types directly ... in my eyes types should be where the soitce files are if they should "match" them ... OR we ned to have one types file then we could also call it types.d.ts and use this ... that would be also clear. so easier to find and easier to see and keep current. And yes add then to package.json

[Aziz-AXG]

Just do as index.d.ts in the src of that project. no need (in my eyes) for another types directly ... in my eyes types should be where the soitce files are if they should "match" them ... OR we ned to have one types file then we could also call it types.d.ts and use this ... that would be also clear. so easier to find and easier to see and keep current. And yes add then to package.json

like this ?