Allow multiple visualizations per page, fixes #32 #39
Conversation
The old behavior is also preserved. This just allows a page to embed the data as oppose to feteching it from a server.
|
@cpsievert did you see this? |
|
Yep, thank you! Hopefully I'll get to it over the weekend! @kshirley might want to look this over as well. |
| /* MIT Licence */ | ||
|
|
||
| 'use strict'; | ||
|
|
There was a problem hiding this comment.
@bmabey I'll admit, I didn't know about "use strict" until now, but it seems like a good idea!
@kshirley In case you're curious, I thought this post does a great job of explaining it -> http://ejohn.org/blog/ecmascript-5-strict-mode-json-and-more/
bmabey
force-pushed
the
allow-multivis-per-page
branch
from
593c854
to
1b1299a
Compare
|
@cpsievert I've removed the |
|
@cpsievert @kshirley how about this PR? Would be very nice to have it merged. I had problems with multiple plots on a single page. |
You could embed them via an |
You can see the updated fix in action here: http://benmabey.com/LDAvis
Included in this PR is another update that allows you to pass the actual data to the visualization object instead of a URI. This change was needed for the IPython integration but is generally useful since it allows you to have a self-contained visualization page that you can send to people.