Merge consensus jobs #8042
Merge consensus jobs #8042
Conversation
…rce_job_id under Job
…ouldn't be updated once Task is created
…ta model to Task model
…core_threshold which are set through extra configuration when creating task
…can be set through API call also when creating task initially
…multiple annotator mode
… passed from frontend to backend
…rted not gt or consensus jobs
… through the parent_job_id
# Conflicts: # cvat-core/src/api.ts # cvat-core/src/server-proxy.ts # cvat-ui/src/components/actions-menu/actions-menu.tsx # cvat-ui/src/components/cvat-app.tsx # cvat-ui/src/containers/actions-menu/actions-menu.tsx # cvat-ui/src/reducers/index.ts # cvat-ui/src/reducers/notifications-reducer.ts # cvat/apps/engine/migrations/0079_job_parent_job_id_task_consensus_jobs_per_segment_and_more.py # cvat/schema.yml
There was a problem hiding this comment.
Here are my ideas for the consensus settings modal:
- Notifications. Lets show that the settings are being saved not by additional notification "updating ..." but by adding a loading icon into the save button. Also, I dont think we need Success notification. Lets not show it eighter. Just close the modal when the save is finished.
- Save/Reset buttons. Need to make 'Save' as 'primary' not 'default. Also, do we really need reset functionality? In quality settings we have lots of settings and dont have reset button. From the other side it can be useful. So, if we want to keep it, I would suggest two things here:
- Change the large button for icon
from ant icons, and place it in the top of the modal
- Instead of resetting right away, we need to confirm this action using simple Modal.confirm
Also its good to add cancel button just to close the modal. So, in the end we will have 'Save' as primary and 'Cancel' as default buttons in this row.
- Merge button. Currently it has some problems with styles, text is not white and backrogund becomes white on hover. From my perspective the action button is too large.
We have a merge icon from the antd. So the bottom menu can look like this:
We can display merge status above the save/cancel as text. Lock the merge button when the process is active. Also we can show a tooltip on hovering the merge icon. What do you think?
| @@ -31,7 +31,7 @@ import Webhook from './webhook'; | |||
| import { ArgumentError } from './exceptions'; | |||
| import { | |||
| AnalyticsReportFilter, QualityConflictsFilter, QualityReportsFilter, | |||
| QualitySettingsFilter, SerializedAsset, | |||
| SettingsFilter, SerializedAsset, | |||
There was a problem hiding this comment.
Why do we rename this? I think SettingsFilter is too broad term.
For me, it refers to some settings inside cvat annotation view.
There was a problem hiding this comment.
The QualitySettingsFilter now not only applies to QualitySettings but also ConsensusSettings.
I think SettingsFilter is too broad term
True, I will think about a better name and then discuss.
There was a problem hiding this comment.
How about AnalyticsSettingsFilter?
|
The consensus tab is not yet ready, am I right? |
Yes, how it will look is yet to be finalised. |
…endpoints to `consensus`
…b` to advanced block in task creation
…b` to advanced block in task creation (cherry picked from commit df460ce44e4039f631953e9ce85ed2531ac760c8)
…on form and set it's max value to 10
…nd stage to `validation`
This, along with the colour and hover action of the rest of the buttons, has been updated.
Should I add a reset button to it, in a separate PR, probably? If we add the reset button on the top right and the merge button on the bottom left as an icon with a tooltip. In that case, isn't there a possibility that it could be missed by users, and they end up searching for the merge button, or might they never use the reset functionality? Or maybe I am overthinking too much. |
Fixes
Aggregating their annotationsandMerging them into the parent jobin #7973Checklist
developbranch- [ ] I have increased versions of npm packages if it is necessary(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.