Fixed timestamp alignment on quality page #8106
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe recent update refines the layout and aesthetics of the quality report controls in the CVAT application's quality page. This includes styling adjustments in the components and reorganization of the report controls with Ant Design's Changes
Sequence Diagram(s)No sequence diagram required as changes pertain to UI layout and styling, without altering the fundamental control flow. Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- changelog.d/20240702_124739_klakhov_fix_quality_timestamp.md (1 hunks)
- cvat-ui/src/components/analytics-page/styles.scss (3 hunks)
- cvat-ui/src/components/analytics-page/task-quality/mean-quality.tsx (2 hunks)
Files skipped from review due to trivial changes (1)
- changelog.d/20240702_124739_klakhov_fix_quality_timestamp.md
Additional comments not posted (19)
cvat-ui/src/components/analytics-page/styles.scss (2)
96-97: LGTM!The added CSS rule ensures that the margin at the end of inline elements is set to 0, which fixes the alignment issue.
132-132: LGTM!The adjusted padding uses a variable for consistency and improves the visual alignment of the quality settings switch.
cvat-ui/src/components/analytics-page/task-quality/mean-quality.tsx (17)
8-8: LGTM!The imported
ColandRowcomponents are necessary for the layout reorganization.
60-60: LGTM!The added
Rowcomponent improves the visual alignment of the quality report controls.
61-61: LGTM!The added
Colcomponent inside theRowcomponent contributes to the layout reorganization.
62-62: LGTM!The nested
Rowcomponent inside theColcomponent further improves the visual alignment of the quality report controls.
63-63: LGTM!The nested
Colcomponent inside theRowcomponent further contributes to the layout reorganization.
64-66: LGTM!The conditional rendering ensures that the
Buttoncomponent is only rendered iftaskReport?.idis defined.
66-75: LGTM!The added
Buttoncomponent with aDownloadOutlinedicon and a link provides a clear and accessible way to download the quality report.
76-76: LGTM!The conditional rendering ensures that the
Buttoncomponent is only rendered iftaskReport?.idis defined.
78-78: LGTM!The nested
Rowcomponent inside theColcomponent further improves the visual alignment of the quality report controls.
80-80: LGTM!The
Rowcomponent with thejustify='end'property ensures that the content is aligned to the end.
81-81: LGTM!The nested
Colcomponent inside theRowcomponent further contributes to the layout reorganization.
82-84: LGTM!The conditional rendering ensures that the timestamp is only rendered if
taskReport?.idis defined.
84-86: LGTM!The added
divelement with thecvat-analytics-time-hintclass displays the timestamp with the appropriate styling.
86-86: LGTM!The
Textcomponent displays the formatted timestamp usingmoment, improving readability.
87-87: LGTM!The conditional rendering ensures that the timestamp is only rendered if
taskReport?.idis defined.
92-92: LGTM!The nested
Colcomponent inside theRowcomponent further contributes to the layout reorganization.
94-97: LGTM!The
SettingOutlinedicon with a click handler provides an accessible way to toggle the quality settings visibility.
|
IMO the both ways of alignment looks a little strange. The text is flying. My proposal is something like this. Thus, it looks similar to performance page.
Also added |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8106 +/- ##
========================================
Coverage 83.40% 83.40%
========================================
Files 389 389
Lines 41297 41297
Branches 3858 3858
========================================
Hits 34442 34442
Misses 6855 6855
|
|
@bsekachev |
|
Motivation and context
The timestamp looks incorrectly aligned + margin after the icon looks too big.
Before:
After:
How has this been tested?
Checklist
developbranch[ ] I have updated the documentation accordingly[ ] I have added tests to cover my changes[ ] I have linked related issues (see GitHub docs)[ ] I have increased versions of npm packages if it is necessary(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.
Summary by CodeRabbit
Bug Fixes
Style
Refactor
RowandColcomponents.