Fixed unexpected deletion of log files of other processes that led to OSError: [Errno 116] Stale file handle error on NFS volumes #8121
Conversation
… OSError: [Errno 116] Stale file handle error on NFS volumes
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe recent updates focus on standardizing the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (8)
- supervisord/server.conf (2 hunks)
- supervisord/utils.conf (3 hunks)
- supervisord/worker.analytics_reports.conf (2 hunks)
- supervisord/worker.annotation.conf (2 hunks)
- supervisord/worker.export.conf (2 hunks)
- supervisord/worker.import.conf (2 hunks)
- supervisord/worker.quality_reports.conf (2 hunks)
- supervisord/worker.webhooks.conf (2 hunks)
Files skipped from review due to trivial changes (5)
- supervisord/server.conf
- supervisord/worker.annotation.conf
- supervisord/worker.import.conf
- supervisord/worker.quality_reports.conf
- supervisord/worker.webhooks.conf
Additional comments not posted (15)
supervisord/worker.analytics_reports.conf (3)
18-18: Good job on improving readability.The added space before the comment delimiter improves readability and consistency.
28-28: Good addition for logging standard output.The
stdout_logfiledirective ensures that the standard output logs are captured in a specific file.
29-29: Good addition for logging standard error.The
stderr_logfiledirective ensures that the standard error logs are captured in a specific file.supervisord/worker.export.conf (4)
18-18: Good job on improving readability.The added space before the comment delimiter improves readability and consistency.
28-28: Good addition for logging standard output.The
stdout_logfiledirective ensures that the standard output logs forrqworker-exportare captured in a specific file.
29-29: Good addition for logging standard error.The
stderr_logfiledirective ensures that the standard error logs forrqworker-exportare captured in a specific file.
29-29: Good addition for logging standard error.The
stderr_logfiledirective ensures that the standard error logs forrqworker-exportare captured in a specific file.supervisord/utils.conf (8)
18-18: Good job on improving readability.The added space before the comment delimiter improves readability and consistency.
28-28: Good addition for logging standard output.The
stdout_logfiledirective ensures that the standard output logs forrqschedulerare captured in a specific file.
29-29: Good addition for logging standard error.The
stderr_logfiledirective ensures that the standard error logs forrqschedulerare captured in a specific file.
37-37: Good addition for logging standard output.The
stdout_logfiledirective ensures that the standard output logs forrqworker-notificationsare captured in a specific file.
38-38: Good addition for logging standard error.The
stderr_logfiledirective ensures that the standard error logs forrqworker-notificationsare captured in a specific file.
39-39: Good addition for ensuring program reliability.The
autorestart=truedirective ensures that therqworker-notificationsprogram will automatically restart on unexpected termination.
49-49: Good addition for logging standard output.The
stdout_logfiledirective ensures that the standard output logs forrqworker-cleaningare captured in a specific file.
50-50: Good addition for logging standard error.The
stderr_logfiledirective ensures that the standard error logs forrqworker-cleaningare captured in a specific file.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8121 +/- ##
===========================================
- Coverage 83.62% 83.39% -0.23%
===========================================
Files 383 389 +6
Lines 40502 41297 +795
Branches 3830 3858 +28
===========================================
+ Hits 33869 34441 +572
- Misses 6633 6856 +223
|
|
Please add a changelog entry. |
azhavoro
force-pushed
the
az/fix_logger_error
branch
from
07438b8
to
f4def17
Compare
| ### Fixed | ||
|
|
||
| - Fixed unexpected deletion of log files of other processes that led to OSError: | ||
| \[Errno 116\] Stale file handle error on NFS volumes |
There was a problem hiding this comment.
Perhaps it's worth mentioning that the logs are now saved in a different directory? This could be an unexpected change for users.
There was a problem hiding this comment.
I added an extra entry to explain this.
|
Due the nocleanup option defaults to false and we use AUTO-generated names for backend process log files, this causes NFS4ERR_STALE to appear on NFS-mounted volumes
http://supervisord.org/configuration.html#:~:text=Introduced%3A%203.0-,nocleanup,-Prevent%20supervisord%20from
https://stackoverflow.com/questions/40262823/stale-file-handle-error-when-process-trying-read-the-file-that-other-process
Motivation and context
How has this been tested?
Checklist
developbranch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.
Summary by CodeRabbit
stdout_logfileandstderr_logfiledirectives for more effective logging and troubleshooting across multiple programs.