-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add max_retries
and timeout
params to all AzureOpenAI
classes
#7945
Comments
Thanks @EdoardoAbatiTR! I'm also opening this for contributions. In case anyone is interested, let's discuss it here. |
Hey, I am new here. Can I assign this to myself? |
@nvzard feel free to work on this. Take a look at the guidelines for contributors. I would suggest creating one PR for each component to be changed. |
Hi all, thank you for working on this :) I think this got closed automatically because there was the "Fixes" keyword the previous PR, but it should stay open until the other classes are also updated |
Ok np @EdoardoAbatiTR, what other classes need to be updated? |
If it's okay for everyone. Can I take a couple of classes? |
@kanjikinsmoke I already have started work for the other classes. I think there are other issues available to work on: https://github.com/deepset-ai/haystack/issues?q=is%3Aopen+is%3Aissue+label%3A%22Contributions+wanted%21%22 |
@kanjikinsmoke we just talked this morning internally about few easy issues that you could potentially work on. I'll ping @julian-risch to get back to you soon |
|
Is your feature request related to a problem? Please describe.
Currently all
OpenAI
related classes (e.g.OpenAIDocumentEmbedder
,OpenAIChatGenerator
) can be initialised by settingmax_retries
andtimeout
params.The corresponding
AzureOpenAI
don't always have the same params.Describe the solution you'd like
It would be nice to have these params in the
AzureOpenAI
classesDescribe alternatives you've considered
Subclass
AzureOpenAI
and create custom components.Additional context
cc @anakin87 :)
The text was updated successfully, but these errors were encountered: