feat: Add max_retries to AzureOpenAIGenerator #7983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I've signed the CLA. |
vblagoje
requested changes
Jul 5, 2024
nvzard
force-pushed
the
feat-azure-open-ai-generator-max-retries
branch
from
f315bfa
to
6338aa2
Compare
|
We need to add reno note @nvzard See https://github.com/deepset-ai/haystack/blob/main/CONTRIBUTING.md for more details |
nvzard
force-pushed
the
feat-azure-open-ai-generator-max-retries
branch
from
6338aa2
to
b77ec92
Compare
|
My bad @vblagoje, I totally forgot about it. |
|
There are still some failures @nvzard |
|
Please let's also read the timeout from an env var if not set at init, as we do in |
nvzard
force-pushed
the
feat-azure-open-ai-generator-max-retries
branch
2 times, most recently
from
fbf9409
to
9d52a77
Compare
|
Good catch @anakin87. I've added it as well. All tests are passing locally now 🤞🏻 |
Pull Request Test Coverage Report for Build 9817242905Details
💛 - Coveralls |
max_retries: if not set is read from the OPENAI_MAX_RETRIES env variable or set to 5. timeout: if not set is read from the OPENAI_TIMEOUT env variable or set to 30. Signed-off-by: Nitanshu Vashistha <[email protected]>
nvzard
force-pushed
the
feat-azure-open-ai-generator-max-retries
branch
from
9d52a77
to
1f3dbdc
Compare
Pull Request Test Coverage Report for Build 9828135301Details
💛 - Coveralls |
|
Thanks for your patience and reviews 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
max_retriesandtimeoutparams to allAzureOpenAIclasses #7945Proposed Changes:
AzureOpenAIGenerator can be initiated using
max_retries.How did you test it?
Unit tests
Notes for the reviewer
I thought it'd be a good idea also to return
max_retrieswhento_dictis called since we are doing it fortimeoutas well. Let me know if this is not required.Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.