Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes:
Add a matrix for the
test
env so we can easily run tests on a different Python version.As of now there's no easy way to run tests on a certain version as Hatch automatically picks Python 3.12 cause of the
default
env Python version costraint>=3.8
.After this change we can run tests like so:
Or:
Calling
hatch run test:unit
will run unit tests on all the Python versions specified in the matrix.How did you test it?
I ran tests locally.
Notes for the reviewer
I had to change some workflows to run only a single version of Python.
In the future we can change our workflows so that the
pyproject.toml
matrix is actually used to generate a job matrix and tests are run for all supported versions.Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.