Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: LinkContentFetcher html text encoding #7975

Merged
merged 4 commits into from
Jul 9, 2024

Conversation

tstadel
Copy link
Member

@tstadel tstadel commented Jul 4, 2024

Related Issues

Proposed Changes:

  • use _binary_content_handler for content type text/html

How did you test it?

  • adjusted tests

Notes for the reviewer

Checklist

@tstadel tstadel requested a review from a team as a code owner July 4, 2024 11:52
@tstadel tstadel requested review from silvanocerza and removed request for a team July 4, 2024 11:52
@github-actions github-actions bot added topic:tests type:documentation Improvements on the docs labels Jul 4, 2024
@tstadel tstadel changed the title Fix/linkcontentfetcher_html_text_encoding fix: LinkContentFetcher html text encoding Jul 4, 2024
@coveralls
Copy link
Collaborator

coveralls commented Jul 4, 2024

Pull Request Test Coverage Report for Build 9793819571

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 19 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.003%) to 89.996%

Files with Coverage Reduction New Missed Lines %
components/fetchers/link_content.py 19 78.02%
Totals Coverage Status
Change from base Build 9790745005: -0.003%
Covered Lines: 6765
Relevant Lines: 7517

💛 - Coveralls

@tstadel tstadel requested a review from a team as a code owner July 4, 2024 12:21
@tstadel tstadel requested review from dfokina and removed request for a team July 4, 2024 12:21
@coveralls
Copy link
Collaborator

coveralls commented Jul 4, 2024

Pull Request Test Coverage Report for Build 9794217995

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 19 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.003%) to 89.996%

Files with Coverage Reduction New Missed Lines %
components/fetchers/link_content.py 19 78.02%
Totals Coverage Status
Change from base Build 9790745005: -0.003%
Covered Lines: 6765
Relevant Lines: 7517

💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Jul 4, 2024

Pull Request Test Coverage Report for Build 9794561737

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 22 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.02%) to 90.015%

Files with Coverage Reduction New Missed Lines %
components/fetchers/link_content.py 8 79.79%
components/converters/azure.py 14 89.55%
Totals Coverage Status
Change from base Build 9790745005: 0.02%
Covered Lines: 6770
Relevant Lines: 7521

💛 - Coveralls

@vblagoje vblagoje added this to the 2.3.0 milestone Jul 9, 2024
@vblagoje vblagoje merged commit 7e35280 into main Jul 9, 2024
17 checks passed
@vblagoje vblagoje deleted the fix/linkcontentfetcher_html_text_encoding branch July 9, 2024 13:28
vblagoje pushed a commit that referenced this pull request Jul 10, 2024
* fix: content encoding of LinkContentFetcher

* fix tests

* add reno

* only touch html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic:tests type:documentation Improvements on the docs
Projects
None yet
4 participants