Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: deterministic uuid generation in UI tests #1168

Merged
merged 22 commits into from
Jul 8, 2024

Conversation

DimaAmega
Copy link
Collaborator

No description provided.

@DimaAmega DimaAmega force-pushed the ui/feature/deterministic-uuid-demo-projects branch from fb775ef to efd0da1 Compare June 22, 2024 22:11
@@ -89,6 +89,8 @@ def create_data():
def create_report(i: int, data):
current, reference, column_mapping = data

# for deterministic tags generation
random.seed(i + 123)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better as a constant in model level

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! Fixed it

@DimaAmega DimaAmega changed the title UI: deterministic uuid generation in demo_projects UI: deterministic uuid generation in UI tests Jun 26, 2024
@@ -20,6 +35,9 @@ def ui(
secret: Optional[str] = Option(None, help="Secret for writing operations"),
):
"""Start Evidently UI service"""
if os.environ.get("EXPERIMENTAL_DETERMINISTIC_UUID"):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DimaAmega DimaAmega merged commit ab9ea17 into main Jul 8, 2024
26 checks passed
@DimaAmega DimaAmega deleted the ui/feature/deterministic-uuid-demo-projects branch July 8, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants