-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: deterministic uuid generation in UI tests #1168
Conversation
fb775ef
to
efd0da1
Compare
@@ -89,6 +89,8 @@ def create_data(): | |||
def create_report(i: int, data): | |||
current, reference, column_mapping = data | |||
|
|||
# for deterministic tags generation | |||
random.seed(i + 123) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better as a constant in model level
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep! Fixed it
@@ -20,6 +35,9 @@ def ui( | |||
secret: Optional[str] = Option(None, help="Secret for writing operations"), | |||
): | |||
"""Start Evidently UI service""" | |||
if os.environ.get("EXPERIMENTAL_DETERMINISTIC_UUID"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
No description provided.