Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added gliner-spacy to universe #13417

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wjbmattingly
Copy link
Contributor

@wjbmattingly wjbmattingly commented Apr 8, 2024

Description

Types of change

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@svlandeg svlandeg added the universe Changes to the Universe directory of third-party spaCy code. label Apr 8, 2024
Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

},
{
"id": "gliner-spacy",
"title": "GLiNER SpaCy Wrapper",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"title": "GLiNER SpaCy Wrapper",
"title": "GLiNER spaCy Wrapper",

Comment on lines +4524 to +4525
"slogan": "Integrating GLiNER's Advanced NER with SpaCy",
"description": "GLiNER SpaCy Wrapper is a project that brings together GLiNER, a zero-shot Named Entity Recognition (NER) model, with SpaCy's NLP capabilities. It provides an easy way to integrate GLiNER within the SpaCy environment, thus enhancing NER tasks with GLiNER's features.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"slogan": "Integrating GLiNER's Advanced NER with SpaCy",
"description": "GLiNER SpaCy Wrapper is a project that brings together GLiNER, a zero-shot Named Entity Recognition (NER) model, with SpaCy's NLP capabilities. It provides an easy way to integrate GLiNER within the SpaCy environment, thus enhancing NER tasks with GLiNER's features.",
"slogan": "Integrating GLiNER's Advanced NER with spaCy",
"description": "GLiNER SpaCy Wrapper is a project that brings together GLiNER, a zero-shot Named Entity Recognition (NER) model, with spaCy's NLP capabilities. It provides an easy way to integrate GLiNER within the spaCy environment, thus enhancing NER tasks with GLiNER's features.",

"website": "https://theirstory.io"
},
"category": ["pipeline"],
"tags": ["gliner", "spacy", "nlp", "ner"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing too generic and too specific tags, to be more in line with other entries in the universe:

Suggested change
"tags": ["gliner", "spacy", "nlp", "ner"]
"tags": ["NER"]

"pip": "gliner-spacy",
"code_example": [
"import spacy",
"from gliner_spacy.pipeline import GlinerSpacy",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This import doesn't seem necessary:

Suggested change
"from gliner_spacy.pipeline import GlinerSpacy",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
universe Changes to the Universe directory of third-party spaCy code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants