Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade[react-devtools-core]: ^5.3.1 #45288

Merged

Conversation

hoxyq
Copy link
Contributor

@hoxyq hoxyq commented Jul 4, 2024

Summary:

We have enabled consoleManagedByDevToolsDuringStrictMode flag for OSS builds in facebook/react#29903 for 0.75. This changed behaviour is supported by RDT 5.3.0, which shipped support for dimming console messages from additional invocations during StrictMode.

This pull request updates react-devtools-core to ^5.3.1, so this is now supported by default in 0.75.

Changelog:

[GENERAL][CHANGED] - Added support for dimming logs in console from additional invocations during StrictMode.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jul 4, 2024
Copy link

github-actions bot commented Jul 4, 2024

Warnings
⚠️ 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against 81da4fd

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 20,443,822 -841,282
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 23,642,501 -839,348
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: f1b6218
Branch: main

@cipolleschi cipolleschi merged commit 2617ec5 into facebook:0.75-stable Jul 8, 2024
90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants