-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility - Keyboard navigation for tooltips and status bar items #1730
Open
e218736
wants to merge
9
commits into
gchq:master
Choose a base branch
from
e218736:tooltips-keyboard-navigation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e218736
changed the title
Tooltips keyboard navigation
Accessibility - Keyboard navigation for tooltips and status bar items
Feb 21, 2024
a3957273
reviewed
Apr 11, 2024
<a href="#" draggable="false" data-val="LS">Line Separator, U+2028</a> | ||
<a href="#" draggable="false" data-val="PS">Paragraph Separator, U+2029</a> | ||
<div class="cm-status-bar-select-content no-select" tabindex="0"> | ||
<a href="#" draggable="false" data-val="LF" tabindex="0">Line Feed, U+000A</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly test whether this is needed and remove if not.
a3957273
reviewed
Apr 11, 2024
const menuItems = element.getElementsByTagName("a"); | ||
menuItems[0].focus(); | ||
|
||
console.log("ev target:", event.target); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove extra logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Issue #1718
This PR aims to solve some of the 'limited keyboard interaction' outlined in section 4/5 of keyboard Navigation in the issue linked above. E.g. Inability to focus on menu items and view tooltips through tabbing, use of arrow keys for navigation within Dropup menus, viewing output timer tool tips.
Code changes:
User-facing changes:
To replicate:
Tab
keyTab
(else keyboard trap in input/output may prevent navigating here correctly)Enter
to open input character encoding/End of line sequence dropupArrowUp
/ArrowDown
to enter dropup and arrow keys to navigate dropup itemsEscape
to close dropup orTab
to exit dropup and navigate away to close