Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lite load perf ci #8222

Merged
merged 12 commits into from
Jul 11, 2024
Merged

Lite load perf ci #8222

merged 12 commits into from
Jul 11, 2024

Conversation

whitphx
Copy link
Member

@whitphx whitphx commented May 6, 2024

Description

Closes: #8193

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented May 6, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website building...
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/ed2f867ac43dd051d5f1712b39ea24a3105e1542/gradio-4.37.2-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@ed2f867ac43dd051d5f1712b39ea24a3105e1542#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-builds.s3.amazonaws.com/ed2f867ac43dd051d5f1712b39ea24a3105e1542/gradio-client-1.2.1.tgz

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented May 6, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/tootils minor
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Lite load perf ci

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@whitphx
Copy link
Member Author

whitphx commented May 21, 2024

@pngwn @freddyaboulton What do you think is an appropriate way to inform the performance measurement result to us from the CI runs?
Use comment-pr extending it to an accept additional key e.g. "functional" for this run type?

@pngwn
Copy link
Member

pngwn commented May 22, 2024

Depends on how we want to display it / how much info there is to display. We could add an additional entry to the table, or we could add another chunk of markdown to the comment, after or before the pip install instructions.

How do you think it would be best to display the info?

@whitphx
Copy link
Member Author

whitphx commented May 22, 2024

@pngwn I think showing a new Markdown section would be good.
At this moment the info to display is only the total loading time,
and perhaps it will be a table with a few rows displaying a bit more detailed durations.

@pngwn
Copy link
Member

pngwn commented May 22, 2024

In that case, it might not need any changes to the action. It the section has a new id which is the first part of the message string id~x~x then if you pass additiona_text which can be any markdown, then it should render in its own section.

@whitphx
Copy link
Member Author

whitphx commented May 22, 2024

@pngwn I tried it (passing functional~success~null as this) but it didn't worked, as looks like the new id must be added to this switch in the action.
Should I add it or is there a simpler way, and if I should, what should the handler look like?

@pngwn
Copy link
Member

pngwn commented May 22, 2024

In this case we actually don't want to add an entry to the table I think, which is mostly what that switch handles iirc.

I will refamiliarise myself with the action and respond shortly.

@abidlabs
Copy link
Member

What's the status of this @whitphx?

@whitphx
Copy link
Member Author

whitphx commented Jul 11, 2024

@pngwn Do you have any idea about how to post messages to the PR pages from the test-functional workflow?
If not, wdyt about merging this PR at this point leaving the posting functionality as a todo?

@pngwn
Copy link
Member

pngwn commented Jul 11, 2024

I forgot to respond shortly.

@pngwn
Copy link
Member

pngwn commented Jul 11, 2024

I think it's good to merge now. We can follow up the PR comment in a new PR.

@abidlabs abidlabs marked this pull request as ready for review July 11, 2024 14:42
@abidlabs
Copy link
Member

Let's go ahead and merge in for the release! Thanks @whitphx

@abidlabs abidlabs merged commit 3a6142f into main Jul 11, 2024
10 checks passed
@abidlabs abidlabs deleted the lite-load-perf-ci branch July 11, 2024 15:30
@pngwn pngwn mentioned this pull request Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Monitor the init loading time in CI
5 participants