-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functionality to add sync gr.Interface
to Hugging Face hub datasets.
#8634
Add functionality to add sync gr.Interface
to Hugging Face hub datasets.
#8634
Conversation
This reverts commit fdcb497.
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/3fde2e2ab1eb583f6529821e336396e02f4b14bc/gradio-4.37.1-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@3fde2e2ab1eb583f6529821e336396e02f4b14bc#subdirectory=client/python" Install Gradio JS Client from this PR npm install https://gradio-builds.s3.amazonaws.com/3fde2e2ab1eb583f6529821e336396e02f4b14bc/gradio-client-1.2.0.tgz |
Thanks @davidberenstein1957 for this PR! I quite like this API though we already have the Is this PR aiming at something else? |
Hi @abidlabs, I did not know this functionality existed and it generally covers the same workflow and functionalities, however, the implemented flagging callback does not work with API calls. With Argilla, we were hoping to find ways to sync datasets, models and of course human feedback a bit better and allow us to make an iterative process of data quality the default for working with models. Having different callback mechanisms is nice but maybe the config along with |
Workflow totally makes sense to me. However, its less clear to me what the current limitations of
|
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
Firstly, when using the Gradio client for API calls/requests, the outputs don't seem to get flagged when using the Also, the usability is partly about the flow where you explicitly need to import I think "flagging" feels a bit more as if it were designed to be reactive as a response to potentially bad examples, while "logging" (everything), which I intend to do, is more pro-active in nature. FYI, we are still exploring how this Argilla back and forth between the hub should work but our initial idea was to create a I think it would be interesting to explore some additional features covering some model card enhancements too. Not saying we should keep my code by the way, but more sharing my reasoning on the idea sketched above, and hope to dive a bit deeper into the matter during a meeting with @pngwn when he is back from his travels @abidlabs, would you like to join too? |
@davidberenstein1957 for sure happy to sync, I do think all of these issues could be solveable though:
Interesting, didn't consider this use case. Sounds like a bug though that we should resolve
We can expose these arguments 👍
That's where the "allow_flagging" argument comes in, though I agree the naming could be better |
just going through and cleaning up prs. @davidberenstein1957 is it okay if I close this for now? happy to sync elsehwere |
Sure, no problem. |
Description
This functionality syncs data from
gr.Interface
to the Hugging Face hub.Stretch: I can also see this being implemented on a lower level with a default processing function per
Component
type, and where people would be able to pass component identifiers as a list to determine what to log. @pngwn @abidlabs WDYT?https://huggingface.co/datasets/davidberenstein1957/bert-tiny-finetuned-sms-spam-detection
🎯 PRs Should Target Issues
Closes: #8635
Not adhering to this guideline will result in the PR being closed.
Tests
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.sh
You may need to run the linters:
bash scripts/format_backend.sh
andbash scripts/format_frontend.sh