Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring the playground component #8691

Closed
wants to merge 3 commits into from

Conversation

whitphx
Copy link
Member

@whitphx whitphx commented Jul 3, 2024

Description

This is not for a specific issue, but just a refactoring what I found during another work.
By using { BaseCode } instead of Code exported from @gradio/code, we can remove some boilerplates.

…nstead of the default-exported Code component
@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Jul 3, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/18469477e2658fca96cfe14517b08b8da89a2fef/gradio-4.37.2-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@18469477e2658fca96cfe14517b08b8da89a2fef#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-builds.s3.amazonaws.com/18469477e2658fca96cfe14517b08b8da89a2fef/gradio-client-1.2.1.tgz

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented Jul 3, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/app minor
gradio minor
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Refactoring the playground component

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@whitphx whitphx marked this pull request as draft July 3, 2024 11:23
@whitphx whitphx marked this pull request as ready for review July 8, 2024 11:06
@whitphx whitphx marked this pull request as draft July 8, 2024 11:07
@whitphx
Copy link
Member Author

whitphx commented Jul 8, 2024

This conflicts with #8693, so will close this for now and create another PR after #8693 is merged.

@whitphx whitphx closed this Jul 8, 2024
@whitphx whitphx deleted the refactoring-playground-element branch July 16, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants