Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Lutron 4 speed fans #121460

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

SquaredCircled
Copy link

Lutron fan controls have 4 speeds.

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Lutron fan controls have 4 speeds.
@home-assistant home-assistant bot added cla-needed integration: lutron small-pr PRs with less than 30 lines. labels Jul 7, 2024
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @SquaredCircled

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

home-assistant bot commented Jul 7, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft July 7, 2024 18:52
@home-assistant
Copy link

home-assistant bot commented Jul 7, 2024

Hey there @cdheiser, @wilburCforce, mind taking a look at this pull request as it has been labeled with an integration (lutron) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of lutron can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign lutron Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@cdheiser
Copy link
Contributor

cdheiser commented Jul 7, 2024

Do fan cards now support 4 speeds? The original design decision by @wilburCforce was to match what the UI supported.

@wilburCforce
Copy link
Contributor

wilburCforce commented Jul 8, 2024

When I inquired with the architects I was told that the fan card would never support 4 speeds. This part of the integration only serves to drive the UI and doesn't impact functionality of the four speeds. You can still set the speed by percentage and create your own cards to present that in the UI. Here is a super rough example I put together:

type: vertical-stack
title: Bedroom Fan
cards:
  - show_name: true
    show_icon: true
    type: button
    tap_action:
      action: call-service
      service: fan.set_percentage
      target:
        entity_id: fan.master_bedroom
      data:
        percentage: 100
    name: High
    icon: mdi:fan-speed-3
    show_state: false
    icon_height: 50px
  - show_name: true
    show_icon: true
    type: button
    tap_action:
      action: call-service
      service: fan.set_percentage
      target:
        entity_id: fan.master_bedroom
      data:
        percentage: 80
    name: Med High
    icon: mdi:fan-speed-3
    show_state: false
    icon_height: 50px
  - show_name: true
    show_icon: true
    type: button
    tap_action:
      action: call-service
      service: fan.set_percentage
      target:
        entity_id: fan.master_bedroom
      data:
        percentage: 40
    name: Medium
    icon: mdi:fan-speed-2
    show_state: false
    icon_height: 50px
  - show_name: true
    show_icon: true
    type: button
    tap_action:
      action: call-service
      service: fan.set_percentage
      target:
        entity_id: fan.master_bedroom
      data:
        percentage: 15
    name: Low
    icon: mdi:fan-speed-1
    show_state: false
    icon_height: 50px

@MartinHjelmare MartinHjelmare changed the title Update fan.py - to support Lutron 4 speed fans Support Lutron 4 speed fans Jul 8, 2024
@SquaredCircled
Copy link
Author

I understand the limits imposed by the HA fan card architecture. It is disappointing they will not be supporting >3 speeds.

Thank you for the proposed template

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants