-
-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add binary sensor to madVR integration #121465
Add binary sensor to madVR integration #121465
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Take a
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
redid to use entity description please let me know if that is correct |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please look into translated names. When the entities have a translation key you can use icon translations to easily change the icon. Also please keep the order of 1. Sensor definitions 2. Async setup entry 3. Sensor classes.
A base class will definitely help you for the future
implemented a base entity and changed it to use translation keys |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong button
added parameterized tests, access update function from mock, misc fixes |
Proposed change
This adds binary sensors to the madvr integration
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: