Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add binary sensor to madVR integration #121465

Merged
merged 12 commits into from
Jul 9, 2024

Conversation

iloveicedgreentea
Copy link
Contributor

@iloveicedgreentea iloveicedgreentea commented Jul 7, 2024

Proposed change

This adds binary sensors to the madvr integration

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@frenck frenck changed the title feat: add binary sensor and tests Add binary sensor to madVR integration Jul 7, 2024
@iloveicedgreentea iloveicedgreentea marked this pull request as ready for review July 7, 2024 20:03
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take a

homeassistant/components/madvr/binary_sensor.py Outdated Show resolved Hide resolved
homeassistant/components/madvr/binary_sensor.py Outdated Show resolved Hide resolved
@home-assistant
Copy link

home-assistant bot commented Jul 7, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft July 7, 2024 20:30
@iloveicedgreentea
Copy link
Contributor Author

redid to use entity description please let me know if that is correct

@iloveicedgreentea iloveicedgreentea marked this pull request as ready for review July 8, 2024 00:06
@home-assistant home-assistant bot requested a review from joostlek July 8, 2024 00:06
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look into translated names. When the entities have a translation key you can use icon translations to easily change the icon. Also please keep the order of 1. Sensor definitions 2. Async setup entry 3. Sensor classes.

A base class will definitely help you for the future

@home-assistant home-assistant bot marked this pull request as draft July 8, 2024 06:25
@iloveicedgreentea
Copy link
Contributor Author

implemented a base entity and changed it to use translation keys

@iloveicedgreentea iloveicedgreentea marked this pull request as ready for review July 9, 2024 03:47
@home-assistant home-assistant bot requested a review from joostlek July 9, 2024 03:47
homeassistant/components/madvr/binary_sensor.py Outdated Show resolved Hide resolved
homeassistant/components/madvr/binary_sensor.py Outdated Show resolved Hide resolved
homeassistant/components/madvr/binary_sensor.py Outdated Show resolved Hide resolved
homeassistant/components/madvr/icons.json Outdated Show resolved Hide resolved
homeassistant/components/madvr/remote.py Outdated Show resolved Hide resolved
homeassistant/components/madvr/strings.json Outdated Show resolved Hide resolved
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong button

@home-assistant home-assistant bot marked this pull request as draft July 9, 2024 05:44
@iloveicedgreentea iloveicedgreentea marked this pull request as ready for review July 9, 2024 13:32
@home-assistant home-assistant bot requested a review from joostlek July 9, 2024 13:32
homeassistant/components/madvr/binary_sensor.py Outdated Show resolved Hide resolved
homeassistant/components/madvr/binary_sensor.py Outdated Show resolved Hide resolved
homeassistant/components/madvr/strings.json Outdated Show resolved Hide resolved
tests/components/madvr/test_binary_sensors.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft July 9, 2024 13:50
@iloveicedgreentea iloveicedgreentea marked this pull request as ready for review July 9, 2024 15:00
@home-assistant home-assistant bot requested a review from joostlek July 9, 2024 15:00
@iloveicedgreentea
Copy link
Contributor Author

added parameterized tests, access update function from mock, misc fixes

@iloveicedgreentea
Copy link
Contributor Author

@joostlek joostlek merged commit 31dc80c into home-assistant:dev Jul 9, 2024
26 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants