Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] Refactor Engine and Diffusion Model(PixArtAlpha/StableDiffusion3) Support #5838

Merged
merged 9 commits into from
Jul 8, 2024
Merged

[Feat] Refactor Engine and Diffusion Model(PixArtAlpha/StableDiffusion3) Support #5838

merged 9 commits into from
Jul 8, 2024

Conversation

LRY89757
Copy link
Contributor

@LRY89757 LRY89757 commented Jun 19, 2024 •
edited
Loading

馃搶 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs
  • I have installed pre-commit: pip install pre-commit && pre-commit install

馃摑 What does this PR do?

  1. Design and Refactor the Engine into DiffusionEngine and LLMEngine with a unified InferenceEngine API
  2. Support Stable Diffusion 3 and PixArtAlpha for our ColossalAI InferenceEngine

Design Doc please see this url

馃挜 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

猸愶笍 Do you enjoy contributing to Colossal-AI?

  • 馃対 Yes, I do.
  • 馃寶 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@LRY89757 LRY89757 requested a review from a team as a code owner June 19, 2024 07:19
@LRY89757 LRY89757 changed the title [Feat] Stable Diffusion 3 Support [Feat] Diffusion Model(PixArtAlpha/StableDiffusion3) Support Jun 26, 2024
@LRY89757 LRY89757 enabled auto-merge (squash) June 26, 2024 07:31
yuanheng-zhao
yuanheng-zhao reviewed Jul 2, 2024
View reviewed changes
colossalai/inference/config.py Outdated Show resolved Hide resolved
colossalai/inference/config.py Outdated Show resolved Hide resolved
colossalai/inference/config.py Outdated Show resolved Hide resolved
colossalai/inference/config.py Outdated Show resolved Hide resolved
colossalai/inference/struct.py Outdated Show resolved Hide resolved
colossalai/inference/core/engine.py Show resolved Hide resolved
colossalai/inference/core/request_handler.py Show resolved Hide resolved
colossalai/inference/utils.py Outdated Show resolved Hide resolved
colossalai/inference/utils.py Show resolved Hide resolved
@LRY89757 LRY89757 changed the title [Feat] Diffusion Model(PixArtAlpha/StableDiffusion3) Support [Feat] Refactor Engine and Diffusion Model(PixArtAlpha/StableDiffusion3) Support Jul 3, 2024
yuanheng-zhao
yuanheng-zhao approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@yuanheng-zhao yuanheng-zhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left some comments and partially approved.

colossalai/inference/utils.py Outdated Show resolved Hide resolved
requirements/requirements.txt Show resolved Hide resolved
LRY89757
LRY89757 commented Jul 8, 2024
View reviewed changes
colossalai/inference/config.py Outdated Show resolved Hide resolved
colossalai/inference/utils.py Outdated Show resolved Hide resolved
@LRY89757 LRY89757 merged commit cba2052 into hpcaitech:main Jul 8, 2024
3 of 6 checks passed
LRY89757 added a commit that referenced this pull request Jul 8, 2024
@LRY89757 @pre-commit-ci
[HotFix] CI,import,requirements-test for #5838 (#5892)
66abf1c 
* [Hot Fix] CI,import,requirements-test

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuanheng-zhao yuanheng-zhao yuanheng-zhao approved these changes

Assignees
No one assigned
Labels
colossal-inference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LRY89757 @yuanheng-zhao