Remove deprecated code #6996
Open
Remove deprecated code #6996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
albertvillanova
commented
Jun 27, 2024
| from typing import TYPE_CHECKING, List, Optional, Union | ||
|
|
||
| import pyarrow as pa | ||
| import pyarrow.parquet as pq | ||
| from tqdm.contrib.concurrent import thread_map | ||
|
|
||
| from .download.download_config import DownloadConfig |
There was a problem hiding this comment.
The removal of this code line makes apparent an underlying circular import that was introduced by:
https://github.com/huggingface/datasets/actions/runs/9694146568/job/26751140360?pr=6996
import datasets
/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/datasets/__init__.py:17: in <module>
from .arrow_dataset import Dataset
/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/datasets/arrow_dataset.py:76: in <module>
from .arrow_reader import ArrowReader
/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/datasets/arrow_reader.py:31: in <module>
from .table import InMemoryTable, MemoryMappedTable, Table, concat_tables
/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/datasets/table.py:13: in <module>
from .utils.logging import get_logger
/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/datasets/utils/__init__.py:17: in <module>
from .info_utils import VerificationMode
/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/datasets/utils/info_utils.py:8: in <module>
from ..exceptions import (
/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/datasets/exceptions.py:8: in <module>
from .table import CastError
E ImportError: cannot import name 'CastError' from partially initialized module 'datasets.table' (most likely due to a circular import) (/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/datasets/table.py)
There was a problem hiding this comment.
I have reverted the removal of this unused import, so that the underlying circular import remain hidden.
I would propose addressing the underlying circular import in a subsequent specific PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove deprecated code, as part of the 3.0 release.
First merge: