feat(mobile): thumbnail alt text #10733
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-basten
commented
Jul 1, 2024
| ); | ||
| } else if (isRemote) { | ||
| return _copyWith( | ||
| localId: localId ?? a.localId, | ||
| width: width ?? a.width, | ||
| height: height ?? a.height, | ||
| exifInfo: exifInfo ?? a.exifInfo?.copyWith(id: id), | ||
| altText: altText ?? a.altText, |
There was a problem hiding this comment.
I'm not sure how to reproduce the scenario in this else if (isRemote) conditional, but the alt text coming from the remote copy should always be preferred.
ben-basten
changed the title
mertalev
reviewed
Jul 3, 2024
ben-basten
force-pushed
the
feat/mobile-alt-text
branch
from
b752032
to
e424909
Compare
ben-basten
force-pushed
the
feat/mobile-alt-text
branch
from
e424909
to
c289e41
Compare
|
Closing for now, as the work is incomplete for the asset viewer. Will reopen when it's ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #10336
Adding alt text to the image thumbnails in the asset grid.
Defaults to the description if present, otherwise it includes the date and location.
How Has This Been Tested?
The testing scenarios that I tried:
Checklist: