Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(server): userinfo signing #10756

Merged
merged 2 commits into from
Jul 11, 2024
Merged

feat(server): userinfo signing #10756

merged 2 commits into from
Jul 11, 2024

Conversation

jrasm91
Copy link
Contributor

@jrasm91 jrasm91 commented Jul 2, 2024 •
edited
Loading

TODO

  • manual testing with signed/unsigned response types
  • verify what happens when signing algorithm is invalid
  • oauth e2e (add oauth server to e2e stack)

image

@bo0tzz bo0tzz self-assigned this Jul 2, 2024
@bo0tzz bo0tzz removed their assignment Jul 10, 2024
@jrasm91 jrasm91 force-pushed the feat/userinfo-signing branch 2 times, most recently from c678242 to 3329385 Compare July 10, 2024 21:15
@jrasm91 jrasm91 mentioned this pull request Jul 10, 2024
Closed
3 tasks
@jrasm91 jrasm91 marked this pull request as ready for review July 10, 2024 21:37
bo0tzz
bo0tzz approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@bo0tzz bo0tzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

zackpollard
zackpollard approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@zackpollard zackpollard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, a Jason PR where code is added though? Not sure how I feel about that 🤣

@jrasm91 jrasm91 merged commit 25a380d into main Jul 11, 2024
22 checks passed
@jrasm91 jrasm91 deleted the feat/userinfo-signing branch July 11, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zackpollard zackpollard zackpollard approved these changes

@bo0tzz bo0tzz bo0tzz approved these changes

@danieldietzler danieldietzler Awaiting requested review from danieldietzler danieldietzler is a code owner

Assignees
No one assigned
Labels
🗄️server 🖥️web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Immich expects a plain JSON object instead of a signed RS256 user info OAuth object
3 participants
@jrasm91 @zackpollard @bo0tzz