fix(mobile): explicit launcher uri for oauth #10832
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
|
🤔 I've got some unexpected localization edits in there. Maybe upstream history changed. I'll reconcile those. |
qrkourier
force-pushed
the
mobile-oauth-scheme
branch
from
d91af9b
to
6651132
Compare
qrkourier
commented
Jul 4, 2024
|
📖 Documentation deployed to pr-10832.preview.immich.app |
|
FYI, in the future, for mobile translation, you only need to modify the |
|
You have some prettier failures, if you could fix those then we can look at this PR |
qrkourier
changed the title
qrkourier
force-pushed
the
mobile-oauth-scheme
branch
from
6651132
to
ded8b29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I get the expected result with the APK build on my Pixel 6 Pro w/ Android 14. Resolves #2932
To test, I used an Auth0 generic web app with allowed callback
app.immich:///, which represents a request for the root/resource fromapp.immichwith a standard://separator between scheme and resource.It's my first contribution so I'll be orienting myself to testing norms after I see what fires off with this submission.
Happy to iterate on this. It will be a breaking change for anyone using mobile OAuth. The fix for them is to modify their IdP to allow callback
app.immich:///. If they're using the mobile callback override URI then it might go unnoticed ifapp.immich:/was successfully launching the app and concluding the login flow. It's not clear to me whether this is currently broken for everyone.