Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(web): show & hide people #10933

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Conversation

michelheusschen
Copy link
Contributor

  • Simplified reactivity on people page
  • Moves logic for updating visibility from the page to a separate component
  • Fixed the toggle visibility button to correctly cycle through hide unnamed --> hide all --> show all. It currently only works for hide unnamed and then gets stuck.
  • Added some unit tests

@alextran1502 alextran1502 merged commit e9683b3 into main Jul 8, 2024
22 checks passed
@alextran1502 alextran1502 deleted the refactor/web-show-hide-people branch July 8, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants