Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add N parameter support #390

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Add N parameter support #390

merged 3 commits into from
Jul 8, 2024

Conversation

AlonsoGuevara
Copy link
Contributor

@AlonsoGuevara AlonsoGuevara commented Jul 5, 2024 •
edited
Loading

Description

  • Add N parameter support
  • Add new parameters to init config
  • update docs

Related Issues

#357

Checklist

  • I have tested these changes locally.
  • I have reviewed the code changes.
  • I have updated the documentation (if necessary).
  • I have added appropriate unit tests (if applicable).

@AlonsoGuevara AlonsoGuevara requested a review from a team as a code owner July 5, 2024 23:59
@AlonsoGuevara AlonsoGuevara mentioned this pull request Jul 6, 2024
Closed
darthtrevino
darthtrevino approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@darthtrevino darthtrevino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you verify that the n argument updates the LLM cache key? If it doesn't this could lead to bad cache responses.

@AlonsoGuevara AlonsoGuevara merged commit b912081 into main Jul 8, 2024
13 checks passed
@AlonsoGuevara AlonsoGuevara deleted the feat/add_n_support_to_models branch July 8, 2024 20:04
@AlonsoGuevara AlonsoGuevara mentioned this pull request Jul 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darthtrevino darthtrevino darthtrevino approved these changes

@natoverse natoverse natoverse left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AlonsoGuevara @darthtrevino @natoverse