Remove size constraints on source files in batched JSON reading #16162
+228
−163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrshi
added
cuIO
vuule
reviewed
Jul 10, 2024
| : std::min(chunk_size, total_source_size - chunk_offset); | ||
|
|
||
| size_t const size_per_subchunk = estimate_size_per_subchunk(chunk_size); | ||
| size_t const batch_size_ub = |
There was a problem hiding this comment.
ub stands for upper bound on the batch size. batch_size_ub is not INTMAX directly since the byte range reader allocates a few more subchunks if the line end is not found in the current chunk. The upper bound is adjusted for this case to prevent overflow.
| // function to extract first delimiter in the string in each chunk, | ||
| // collate together and form byte_range for each chunk, | ||
| // parse separately. | ||
| std::vector<cudf::io::table_with_metadata> skeleton_for_parellel_chunk_reader( |
There was a problem hiding this comment.
this reimplements the block reading support with the public API?
| batch_offsets.push_back(pref_bytes_size); | ||
| for (size_t i = start_source; i < sources.size() && pref_bytes_size < end_bytes_size;) { | ||
| pref_source_size += sources[i]->size(); | ||
| while (pref_bytes_size < end_bytes_size && |
There was a problem hiding this comment.
Maybe a few more comments here, since this non-trivial logic is the core of the feature.
For example something like "break the current source into batches" could go above this line
github-actions
bot
added
libcudf
|
Notes on the json tests cleanup(?) exercise:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses #16138
The batched multi-source JSON reader fails when the size of any of the input source buffers exceeds
INT_MAXbytes.The goal of this PR is to remove this constraint by modifying the batching behavior of the reader. Instead of constructing batches that include entire source files, the batches are now constructed at the granularity of byte ranges of size at most
INT_MAXbytes,Checklist