Move kernel vis over to CUDF_HIDDEN #16165
Open
+18
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertmaynard
added
feature request
robertmaynard
force-pushed
the
fea/use_cudf_hidden_for_cuda_kernels
branch
from
73868c9
to
39a8ae4
Compare
robertmaynard
force-pushed
the
fea/use_cudf_hidden_for_cuda_kernels
branch
from
39a8ae4
to
cd1d047
Compare
PointKernel
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use CUDF_HIDDEN instead of the raw
__attribute__((visibility("hidden")))for symbol visibility controls on the CUDA kernels that we call from multiple TUs. This is primarily a style change so that we have consistent visibility markup across the entire projectChecklist