Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate pylibcudf lists gathering #16170

Merged
merged 7 commits into from
Jul 9, 2024
Merged

Migrate pylibcudf lists gathering #16170

merged 7 commits into from
Jul 9, 2024

Conversation

Matt711
Copy link
Contributor

@Matt711 Matt711 commented Jul 2, 2024

Description

Apart of #15162

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@Matt711 Matt711 requested a review from a team as a code owner July 2, 2024 15:20
@github-actions github-actions bot added Python Affects Python cuDF API. pylibcudf Issues specific to the pylibcudf package labels Jul 2, 2024
@Matt711 Matt711 added feature request New feature or request 3 - Ready for Review Ready for review by team non-breaking Non-breaking change and removed Python Affects Python cuDF API. labels Jul 2, 2024
@rapidsai rapidsai deleted a comment from copy-pr-bot bot Jul 2, 2024
@Matt711 Matt711 mentioned this pull request Jul 2, 2024
Open
@Matt711 Matt711 self-assigned this Jul 2, 2024
lithomas1
lithomas1 approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@lithomas1 lithomas1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this LGTM!

Left one comment, though.

python/cudf/cudf/_lib/pylibcudf/lists.pxd Outdated Show resolved Hide resolved
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jul 8, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the Python Affects Python cuDF API. label Jul 8, 2024
@Matt711
Copy link
Contributor Author

Matt711 commented Jul 9, 2024

/merge

@rapids-bot rapids-bot bot merged commit 248b2de into rapidsai:branch-24.08 Jul 9, 2024
82 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lithomas1 lithomas1 lithomas1 approved these changes

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@Matt711 Matt711

Labels
3 - Ready for Review Ready for review by team feature request New feature or request non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Status: Done
pylibcudf
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Matt711 @lithomas1