Migrate lists/sorting to pylibcudf #16179
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matt711
added
feature request
lithomas1
reviewed
Jul 10, 2024
| expect = pa.array(expected) | ||
|
|
||
| assert_column_eq(expect, res) | ||
| assert_column_eq(expect, res_stable) |
There was a problem hiding this comment.
Can we add test cases where the stable sort/non stable sort result is not the same?
(i.e. one where we have duplicates?)
There was a problem hiding this comment.
I can but I don't think the output diff wouldn't be noticeable unless you can sort by key
| The input column. | ||
| ascending : bool | ||
| If true, the sort order is ascending. Otherwise, the sort order is descending. | ||
| na_position : str |
There was a problem hiding this comment.
I think it might be better to just have the user pass in a NullOrder enum (since that is exposed to Python).
The order enum might also be exposed (but like having a boolean for order better).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apart of #15162
Checklist