Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: [NOT READY FOR REVIEW] split up CUDA-suffixed dependencies in dependencies.yaml #16183

Draft
wants to merge 5 commits into
base: branch-24.08
Choose a base branch
from

Conversation

jameslamb
Copy link
Member

Description

Contributes to rapidsai/build-planning#31
Contributes to rapidsai/build-planning#68

Follow-up to #15425.

RAPIDS DLFW builds prefer to build all RAPIDS packages together without CUDA suffixes, leading to the following set of requirements for cudf wheels built there:

  • project name must be cudf (not cudf-cu12)
  • all dependencies must be unsuffixed (e.g. rmm not rmm-cu12)
  • the correct set of dependencies based on CUDA version must be expressed in the wheel metadata (e.g. cubinlinker and ptxcompiler on CUDA 11, pynvjitlink on CUDA 12)

To meet all 3 of those, this proposes decomposing CUDA-suffixed dependencies in dependencies.yaml into two lists... cuda_suffixed="true" and cuda_suffixed="false".

That'd allow DLFW builds to do the following to meet its requirements:

pip wheel \
  -C rapidsai.disable-cuda=true \
  -C rapidsai.matrix-entry="cuda=12.5;cuda_suffixed=false" \
  .

While in here touching this, I've also changed the fallback matrices (the ones used when no CUDA version is supplied) to the CUDA 12 set of dependencies, following @bdice 's suggestion described in rapidsai/build-planning#68.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jameslamb jameslamb added 2 - In Progress Currently a work in progress improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 2, 2024
@github-actions github-actions bot added the Python Affects Python cuDF API. label Jul 2, 2024
@github-actions github-actions bot added the cudf.polars Issues specific to cudf.polars label Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - In Progress Currently a work in progress cudf.polars Issues specific to cudf.polars improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

None yet

1 participant