Migrate lists/filtering to pylibcudf #16184
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matt711
added
feature request
| A Column of filtered elements based upon the boolean mask. | ||
| """ | ||
| cdef unique_ptr[column] c_result | ||
| cdef ListColumnView list_view1 = input.list_view() |
There was a problem hiding this comment.
I think we should call these input_view and mask_view or similar.
|
|
||
|
|
||
| def test_apply_boolean_mask(test_data, bool_column): | ||
| list_column = test_data[0][0] |
There was a problem hiding this comment.
what do you think about making this one a its own fixture since it's used so much throughout the file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apart of #15162
Checklist