Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use resource_ref for upstream in stream_checking_resource_adaptor #16187

Open
wants to merge 2 commits into
base: branch-24.08
Choose a base branch
from

Conversation

harrism
Copy link
Member

@harrism harrism commented Jul 3, 2024

Description

As we move toward replacing all device_memory_resource pointers with resource_refs, there are some places that changes can be made ahead of RMM to simplify required changes as RMM is refactored.

In this PR I eliminate the unnecessary Upstream template parameter from cudf_test::stream_checking_resource_adaptor, and use a device_async_resource for the upstream resource. A similar change will be made to all RMM resource adaptors, but this one can be done without deprecations since it is just a test utility.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@harrism harrism requested a review from a team as a code owner July 3, 2024 08:47
@harrism harrism requested review from bdice and nvdbaranec July 3, 2024 08:47
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Jul 3, 2024
@harrism harrism added feature request New feature or request non-breaking Non-breaking change labels Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

None yet

1 participant