Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate lists/filling to pylibcudf #16189

Open
wants to merge 1 commit into
base: branch-24.08
Choose a base branch
from
Open

Migrate lists/filling to pylibcudf #16189

wants to merge 1 commit into from

Conversation

Matt711
Copy link
Contributor

@Matt711 Matt711 commented Jul 3, 2024

Description

Apart of #15162

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@Matt711 Matt711 added feature request New feature or request non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package labels Jul 3, 2024
@Matt711 Matt711 self-assigned this Jul 3, 2024
@Matt711 Matt711 requested a review from a team as a code owner July 3, 2024 15:07
@github-actions github-actions bot added the Python Affects Python cuDF API. label Jul 3, 2024
Matt711
Matt711 commented Jul 3, 2024
View reviewed changes
python/cudf/cudf/pylibcudf_tests/test_lists.py
Comment on lines +140 to +142
starts = plc.interop.from_arrow(pa.array([0, 1, 2, 3, 4]))
steps = plc.interop.from_arrow(pa.array([2, 1, 1, 1, -3]))
sizes = plc.interop.from_arrow(pa.array([0, 2, 2, 1, 3]))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't create fixtures because these columns will only be used in this test

@Matt711 Matt711 requested a review from lithomas1 July 15, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice Awaiting requested review from bdice bdice is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@lithomas1 lithomas1 Awaiting requested review from lithomas1

At least 1 approving review is required to merge this pull request.

Assignees

@Matt711 Matt711

Labels
feature request New feature or request non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Status: In Progress
pylibcudf
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Matt711