-
Notifications
You must be signed in to change notification settings - Fork 872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate lists/set_operations to pylibcudf #16190
base: branch-24.08
Are you sure you want to change the base?
Migrate lists/set_operations to pylibcudf #16190
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, some minor comments r.e. docs and testing
|
||
res = set_operation( | ||
plc.interop.from_arrow(pa.array(lhs)), | ||
plc.interop.from_arrow(pa.array(rhs)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you parametrize this test for nulls_equal/nans_equal as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I can for nulls_equal
. I thinknans_equal
is a bit trickier to test because of how cudf handles missing data. Can you think of any test columns I can use (lhs and rhs) to test nan_equal=False
?
For now I left all nan_equal
argument as True.
Description
Apart of #15162
Checklist