Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] JSON tree algorithms refactor II: Constructing device JSON column #16205

Draft
wants to merge 11 commits into
base: branch-24.08
Choose a base branch
from
Draft

[WIP] JSON tree algorithms refactor II: Constructing device JSON column #16205

wants to merge 11 commits into from

Conversation

shrshi
Copy link
Contributor

@shrshi shrshi commented Jul 6, 2024 •
edited
Loading

Description

Part of #15903.
NOTE: This PR depends on the previous PR #15979 which introduces the CSR storage for the column tree.

  • Identifies string columns that have nested columns as siblings, and discards them
  • Merge device_json_column with column_tree_csr struct

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jul 6, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Jul 6, 2024
@shrshi shrshi added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
cuDF/Dask/Numba/UCX
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@shrshi