Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Fix random port conflict from dashboard agent #46437

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Superskyyy
Copy link
Contributor

This PR fixes an issue where the dashboard agent default port 52365 could be taken by other components if unlucky. The changes both prevent this specific case and is future proof now. Closes:#45484

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@Superskyyy Superskyyy changed the title Fix random port conflict from dashboard agent [Core] Fix random port conflict from dashboard agent Jul 4, 2024
@Superskyyy
Copy link
Contributor Author

oops, local lint didn't show the problem. gonna fix it tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant