Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[spark] Fix Ray on Spark fractional GPU error #46443

Merged
merged 7 commits into from
Jul 10, 2024
Merged

[spark] Fix Ray on Spark fractional GPU error #46443

merged 7 commits into from
Jul 10, 2024

Conversation

WeichenXu123
Copy link
Contributor

Why are these changes needed?

Fix error reported in #39537

Related issue number

Closes #39537

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@WeichenXu123
init
258c021 
Signed-off-by: Weichen Xu <[email protected]>
@WeichenXu123
Copy link
Contributor Author

CC @jjyao

@WeichenXu123
format
cb77f9c 
Signed-off-by: Weichen Xu <[email protected]>
@WeichenXu123
update
e03623e 
Signed-off-by: Weichen Xu <[email protected]>
@WeichenXu123
format
9dec759 
Signed-off-by: Weichen Xu <[email protected]>
@WeichenXu123 WeichenXu123 requested a review from jjyao July 9, 2024 10:02
@jjyao jjyao added the go add ONLY when ready to merge, run all tests label Jul 9, 2024
jjyao
jjyao approved these changes Jul 10, 2024
View reviewed changes
python/ray/util/spark/cluster_init.py Outdated Show resolved Hide resolved
python/ray/util/spark/cluster_init.py Outdated Show resolved Hide resolved
@WeichenXu123
update
037dff3 
Signed-off-by: Weichen Xu <[email protected]>
@WeichenXu123
Copy link
Contributor Author

@jjyao Done!

@jjyao jjyao merged commit c103330 into ray-project:master Jul 10, 2024
5 checks passed
Catch-Bull pushed a commit to Catch-Bull/ray that referenced this pull request Jul 15, 2024
@WeichenXu123
[spark] Fix Ray on Spark fractional GPU error (ray-project#46443)
fc0c988 
Signed-off-by: Weichen Xu <[email protected]>
Signed-off-by: hejialing.hjl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjyao jjyao jjyao approved these changes

Assignees
No one assigned
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ray on Spark fractional GPU error calling setup_ray_cluster
2 participants
@WeichenXu123 @jjyao