[RLlib] Cleanup examples folder vol19: Add example script for custom loss function (new API stack). #46445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sven1977 <[email protected]>
sven1977
requested review from
ArturNiederfahrenhorst and
simonsays1980
as code owners
Signed-off-by: sven1977 <[email protected]>
simonsays1980
approved these changes
Jul 8, 2024
| @@ -2116,6 +2118,11 @@ def training( | |||
| should set this setting to False. | |||
| Note that this setting is only relevant if the new API stack is used | |||
| (including the new EnvRunner classes). | |||
| learner_config_dict: A dict to insert any settings accessible from within | |||
There was a problem hiding this comment.
Although I am voting for simplicity, I do not like this many roads lead to Rome approach. Overiding the AlgorithmConfig is not too sophisticated imo and the user is now confrotned with the question what to use when. I consider a single truth approach as less confusing even though here a bit more effort is needed. But this is my taste.
There was a problem hiding this comment.
Maybe you are right. It definitely adds another option to get tangled up in. ...
Let me think about this more ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup examples folder vol19: Add example script for custom loss function (new API stack).
Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.